Skip to content

wip refactor(application-generic): update strict null checks to true #8332

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 2 commits into
base: next
Choose a base branch
from

Conversation

djabarovgeorge
Copy link
Contributor

@djabarovgeorge djabarovgeorge commented May 19, 2025

What changed? Why was the change needed?

EE-PR

Screenshots

Expand for optional sections

Related enterprise PR

Special notes for your reviewer

- Updated subproject commit reference.
- Added `LOGGING_LEVEL` validation to environment validators in both API and worker configurations.
- Changed `STORE_ENCRYPTION_KEY` to use `str32()` for stricter validation.
- Enabled strict null checks in TypeScript configuration for better type safety.
- Refactored various handlers to ensure optional chaining and default values for credentials.
- Improved error handling and logging across services.
Copy link

netlify bot commented May 19, 2025

Deploy Preview for dashboard-v2-novu-staging failed. Why did it fail? →

Name Link
🔨 Latest commit 583fae6
🔍 Latest deploy log https://app.netlify.com/projects/dashboard-v2-novu-staging/deploys/683c3c84d6acdb0008964514

@djabarovgeorge djabarovgeorge changed the title refactor(application-generic): update strict null checks to true wip refactor(application-generic): update strict null checks to true May 19, 2025
Copy link

github-actions bot commented May 19, 2025

Hey there and thank you for opening this pull request! 👋

We require pull request titles to follow the Conventional Commits specification and it looks like your proposed title needs to be adjusted.

Your PR title is: wip refactor(application-generic): update strict null checks to true
It should be something like: feat(scope): Add fancy new feature

Details:

No release type found in pull request title "wip refactor(application-generic): update strict null checks to true". Add a prefix to indicate what kind of release this pull request corresponds to. For reference, see https://www.conventionalcommits.org/

Available types:

  • feat: A new feature
  • fix: A bug fix
  • docs: Documentation only changes
  • style: Changes that do not affect the meaning of the code (white-space, formatting, missing semi-colons, etc)
  • refactor: A code change that neither fixes a bug nor adds a feature
  • perf: A code change that improves performance
  • test: Adding missing tests or correcting existing tests
  • build: Changes that affect the build system or external dependencies (example scopes: gulp, broccoli, npm)
  • ci: Changes to our CI configuration files and scripts (example scopes: Travis, Circle, BrowserStack, SauceLabs)
  • chore: Other changes that don't modify src or test files
  • revert: Reverts a previous commit

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant